refactor: simplify group name normalization and cache returns - #50
Merged
Conversation
Derive the normalized-to-original map from the collected original names instead of building a second dict, and return the local tuple in _parse_group/_resolve instead of reading it back from the cache. Refs #45 Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
henryiii
force-pushed
the
simplify-normalize-and-cache
branch
from
August 5, 2026 23:55
5cc8a2b to
036a0a4
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
sirosen
approved these changes
Aug 6, 2026
sirosen
left a comment
sirosen
left a comment
Contributor
There was a problem hiding this comment.
I misunderstood what the proposed simplification was earlier. This looks nice; cool!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Applies the "Simplifications" section of #45.
_normalize_group_namesno longer builds a secondnormalized_to_originaldict. After the duplicate check, the map is derivable fromoriginal_names(names[0])._parse_groupand_resolvereturn a local tuple instead of assigning to the cache dict and reading it back.No behavior change.
📚 Documentation preview 📚: https://dependency-groups--50.org.readthedocs.build/en/50/